Rename popup classes to use consistent naming convention#22
Merged
Conversation
The built-in popups were moved from the abap2UI5 core framework (obsolete package src/99/02) to the abap2UI5-addons/popups repository. Switch all usages to the new class names, add the popups repo as an abaplint dependency and document the new dependency in the README. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUm2VFnKDYma7WNGyBT3qb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates all references to popup classes to use a consistent naming convention, renaming classes from
z2ui5_cl_pop_*toz2ui5_cl_popup_*throughout the codebase.Key Changes
z2ui5_cl_pop_to_confirm→z2ui5_cl_popup_to_confirmz2ui5_cl_pop_error→z2ui5_cl_popup_errorz2ui5_cl_pop_get_range_m→z2ui5_cl_popup_get_range_mz2ui5_sql_cl_app_01classzcl_2ui5_native_sql_consoleclass and its local implementationserror_acknowledged_interactionfromZ2UI5_CL_POP_ERRORtoZ2UI5_CL_POPUP_ERRORpopupsaddon inabaplint.jsoncImplementation Details
https://claude.ai/code/session_01EUm2VFnKDYma7WNGyBT3qb