Skip to content

Rename popup classes to use consistent naming convention#22

Merged
oblomov-dev merged 1 commit into
mainfrom
claude/abap2ui5-popup-usage-plpspy
Jul 12, 2026
Merged

Rename popup classes to use consistent naming convention#22
oblomov-dev merged 1 commit into
mainfrom
claude/abap2ui5-popup-usage-plpspy

Conversation

@oblomov-dev

Copy link
Copy Markdown
Member

Summary

This PR updates all references to popup classes to use a consistent naming convention, renaming classes from z2ui5_cl_pop_* to z2ui5_cl_popup_* throughout the codebase.

Key Changes

  • Renamed class references:
    • z2ui5_cl_pop_to_confirmz2ui5_cl_popup_to_confirm
    • z2ui5_cl_pop_errorz2ui5_cl_popup_error
    • z2ui5_cl_pop_get_range_mz2ui5_cl_popup_get_range_m
  • Updated all type declarations and method signatures in z2ui5_sql_cl_app_01 class
  • Updated all type declarations and method implementations in zcl_2ui5_native_sql_console class and its local implementations
  • Updated class identifier string in error_acknowledged_interaction from Z2UI5_CL_POP_ERROR to Z2UI5_CL_POPUP_ERROR
  • Added dependency reference to the popups addon in abaplint.jsonc
  • Updated README.md to document the new dependency on the popups addon

Implementation Details

  • All changes maintain backward compatibility at the functional level - only class names are updated
  • The renaming is applied consistently across both main application code and native SQL console implementation
  • The popup addon is now explicitly declared as a dependency in the project configuration

https://claude.ai/code/session_01EUm2VFnKDYma7WNGyBT3qb

The built-in popups were moved from the abap2UI5 core framework
(obsolete package src/99/02) to the abap2UI5-addons/popups repository.
Switch all usages to the new class names, add the popups repo as an
abaplint dependency and document the new dependency in the README.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EUm2VFnKDYma7WNGyBT3qb
@oblomov-dev
oblomov-dev merged commit 6caacdb into main Jul 12, 2026
@oblomov-dev
oblomov-dev deleted the claude/abap2ui5-popup-usage-plpspy branch July 12, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants