Standardize type naming conventions across demo apps#633
Merged
Conversation
- Replace single-quote char literals with backtick string literals in currency demo data of apps 060 and 201, and in dynamic calls of app 365 - Use string templates instead of && concatenation for the search range in apps 060/201 and for the labels in app 295 - Rename type/attribute in app 295 to follow naming conventions (ty_s_data, t_data) and make the label prefix a local variable - Remove unnecessary lv_ prefix from scalar variable in app 365 - Remove dead empty on_init method, unused catch variable with TODO comment and stale attribute names in a toast message in app 342 - Move get_comp from private to protected section in app 342 - Normalize blank lines: max 1 inside methods (app 000), 1 at method body start/end and 2 between methods (apps 339, 342, 035 locals) - Fix parameter alignment in app 342 and a typo in app 035 demo text Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YZqfMrZB3XTSwQBesLNN3W
- Inline single-use table types per convention (declare STANDARD TABLE OF directly at the DATA/CREATE DATA statement) in apps 052, 053, 070, 071, 100, 164, 199, 211 and 364; remove the unused ty_t_combo type in app 084 and the unused ty_s_suggest/ty_t_suggest types in the app 035 locals - Rename table attribute lt_combo to t_combo in app 071 - Add missing empty PROTECTED/PRIVATE sections to the local helper classes of apps 017 and 042 - Normalize blank lines in class definitions: one blank line above each section keyword after a non-empty section (34 files), none directly below a section keyword, none between empty sections and none above ENDCLASS (apps 035/042 locals, 361) - Normalize two blank lines between ENDCLASS and IMPLEMENTATION in the locals of apps 017, 035 and 042, and a single blank line after the IMPLEMENTATION statement in apps 184 and 192 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YZqfMrZB3XTSwQBesLNN3W
- Remove the extra blank line between the client assignment and the IF in pure dispatcher main methods, matching the canonical template (58 files) - Fix typos in tile texts and class descriptions: subseequentStetps to subsequentSteps (apps 999, 202) and "basic- timer" to "basic - timer" (apps 999, 028) - Unify branding in page titles to "abap2UI5 - ..." in apps 118 and 134 - Add missing blank line before the view factory call in app 080 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YZqfMrZB3XTSwQBesLNN3W
- Add the missing blank line directly after the condition line in IF/ELSEIF/ELSE branches that contain more than one statement (94 spots across 81 files) - Collapse double blank lines inside method bodies to a single blank line in apps 190, 194, 212, 361 and 999 - Remove unnecessary me-> prefixes on attribute access in app 312 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YZqfMrZB3XTSwQBesLNN3W
- Move the client attribute from the public to the protected section in 38 apps, following the canonical app template (no external or inheriting code accesses it) - Remove leftover commented-out fragments after object_identifier calls in apps 337, 339, 342, 344, 345, 347 and 349 - Add the missing blank line before an IF block after an assignment in app 362 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YZqfMrZB3XTSwQBesLNN3W
Rename 114 TYPES ... BEGIN OF structure types across 74 apps to carry the ty_s_ prefix (e.g. ty_row to ty_s_row, s_combobox to ty_s_combobox, ts_screen to ty_s_screen, t_token to ty_s_token). All renames are local to their class - no cross-class type references exist - and were guarded against name collisions, equally named data objects and occurrences in binding strings. Nested structure components keep their names. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YZqfMrZB3XTSwQBesLNN3W
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR standardizes type naming conventions across all demo app classes to follow the project's established naming guidelines. The changes ensure consistent use of
ty_s_prefix for structure types andty_t_prefix for table types throughout the codebase.Key Changes
t_,s_,ts_,ty_a_,ty_t_) to the standardty_s_prefix for all structure typest_subtask5→ty_s_subtask5,ty_node4→ty_s_node4,ty_a_data→ty_s_data,ts_data_chart→ty_s_data_chartty_t_prefix consistentlyEMPTY_LINES_IN_CLASS_DEFINITIONandEMPTY_LINES_WITHIN_METHODSruleson_initmethod declaration inz2ui5_cl_demo_app_342and ensured proper method orderingImplementation Details
src/,src/02/,src/03/, andsrc/99/directoriesty_s_for structures,ty_t_for tablesThese changes ensure the codebase adheres to the SAP ABAP Style Guide and project conventions as documented in
CLAUDE.md.https://claude.ai/code/session_01YZqfMrZB3XTSwQBesLNN3W