Fix abapGit import errors caused by source lines over 255 characters - #669
Merged
Conversation
ABAP limits source lines to 255 characters; longer lines break the import with "Literals across more than one line are not allowed". The merged reorganization contained such lines, and the failed import left z2ui5_cl_demo_app_038 and _378 as empty class stubs and reverted the sample_app_001 catalog to its old single-group state. - restore the aligned implementations of app 038 and 378 with their long literals split into short && chunks - generate-launchpad.js: wrap catalog rows whose sub would exceed the limit across multiple lines (sub split into && chunks) - regenerate sample_app_001, restoring the per-library groups and the full demo kit descriptions - enforce the limit via the abaplint line_length rule (255) and document it in AGENTS.md Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016NuzrYKkzoSiM7jnMBKee4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The reorganization merged with #668 contained source lines longer than the hard ABAP limit of 255 characters per line, which broke the abapGit import with
Literals across more than one line are not allowed. The failed import then leftz2ui5_cl_demo_app_038andz2ui5_cl_demo_app_378as empty class stubs onstandardand reverted thesample_app_001catalog to its old single-group state.This PR restores the lost content and removes the root cause:
&&chunksgenerate-launchpad.js: wrap catalog rows whosesubwould exceed the 255-char limit across multiple lines (sub literal split into&&chunks)sample_app_001, restoring the per-librarycontrols - sap.*groups and the full demo kit descriptionsline_lengthrule (255) so this fails in CI instead of at import time, and document it in AGENTS.mdVerification
awk 'length > 255'over all.abapsources: no hitsnpx abaplint: 0 issues (756 files), including the newline_lengthrule🤖 Generated with Claude Code
https://claude.ai/code/session_016NuzrYKkzoSiM7jnMBKee4
Generated by Claude Code