Take the widened prose check from the source repository - #806
Merged
Conversation
abap2UI5 owns .github/shared/check-prose-names.mjs and this is a byte-equal copy, held so by that repository's check:shared - which is red until every consumer carries the same bytes. Two changes, both made there: docs/ is now walked recursively, and the dead STATUS-history.md exclusion is replaced by one matching docs/history.md, since a journal records what a class was called when the entry was written. Widening it to docs/ produces no new findings here - checked before taking it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
scripts/check-prose-names.mjsis a byte-equal copy of abap2UI5's.github/shared/check-prose-names.mjs. That file gained two fixes inabap2UI5#2674, so abap2UI5's own
npm run check:sharedis red until everyconsumer carries the same bytes. This takes them.
The two changes, both made at the source:
docs/is now walked recursively. The prose set never included anythingunder
docs/, so pages that cite class and control names constantly wereoutside the gate entirely. In samples-controls that is exactly where a stale
claim had survived.
STATUS-history.mdexclusion is replaced by one matchingdocs/history.md. The old pattern named a file that no longer exists, so itexcluded nothing; the replacement keeps journals out on purpose, because a
journal records what a class was called when the entry was written, not what
it is called now.
Verification
Run here before taking it:
node scripts/check-prose-names.mjsreports25 class names across 4 prose files, all of them real — no new findings,
nothing to allowlist. This repository was already clean under the wider check.
For contrast, samples-controls needed four
prose-absent.jsonentries(abap2UI5/samples-controls#159); this one needs none.
Generated by Claude Code