PR: [issue: 672] add __version__ #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@janvdp thank you, looks good to me! I think you can also specify |
Closed
Contributor
Author
|
@abetlen Thanks for the pyproject feedback. In addition to setting the "version" to dynamic, the setuptools doc state that you need to read the version: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html I have created a PR for this: #713 I don't have a way to test it, so let me know if that it works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a PR for #672 adding the
__version__.This PR includes the features mentioned in the issue, but no changes have been made to support poetry automatically using the llama_cpp/version.py version.
If you merge this PR as is, you still need to update llama_cpp/version.py as well as pyproject.toml.
Feel free to already merge, or provide feedback as to first adding poetry support.