Update pyproject.toml #713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dynamic version to pyproject.toml
Owner
|
Hey @janvdp from version 0.2 on I started using the dynamic metadata regex tool from https://scikit-build-core.readthedocs.io/en/latest/configuration.html#dynamic-metadata to set the version which is now found in the root |
Contributor
Author
|
@abetlen Aha, thanks for the info. I did not know. Had a look at the docs, found it a little obscure, but if it works, let's roll. Safe to reject/delete this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional PR for #684
Updated pyproject.toml to read the version dynamically following the setuptools docs: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html