chore: update ruff config to use lint section#706
Conversation
Co-authored-by: abhimehro <84992105+abhimehro@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
There was a problem hiding this comment.
No application code in the PR — skipped Code Health checks.
See analysis details in CodeScene
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Ruff configuration to the newer schema by moving lint rule configuration under the [lint] table, avoiding deprecation warnings with newer Ruff versions.
Changes:
- Introduces a
[lint]section in.trunk/configs/ruff.toml. - Keeps the existing
selectandignorerule lists, now correctly scoped under[lint].
There was a problem hiding this comment.
Code Review
This pull request updates the Ruff configuration in .trunk/configs/ruff.toml by adding a [lint] section header. Feedback was provided regarding a significant inconsistency between this configuration and the one defined in pyproject.toml, which could result in different linting outcomes depending on the tool used. It is recommended to synchronize these configurations for consistency.
| @@ -1,4 +1,5 @@ | |||
| # Generic, formatter-friendly config. | |||
| [lint] | |||
There was a problem hiding this comment.
The Ruff configuration in this file is significantly inconsistent with the one defined in pyproject.toml. For instance, this file includes flake8-bugbear (B) and pydocstyle (D3, D4) which are absent from pyproject.toml, while pyproject.toml includes several other plugins (W, N, PERF, RET, SIM, UP) that are missing here. This discrepancy can lead to different linting results depending on whether Ruff is invoked via Trunk or directly. Consider synchronizing these configurations to ensure consistent code quality checks across all environments.
This commit updates the
.trunk/configs/ruff.tomlconfiguration by migrating the deprecated top-levelselectandignoresettings into a new[lint]section, eliminating deprecation warnings when running Ruff.PR created automatically by Jules for task 11248897609115947819 started by @abhimehro