Skip to content

chore: update ruff config to use lint section#706

Merged
abhimehro merged 1 commit into
mainfrom
chore/ruff-config-fix-11248897609115947819
Apr 6, 2026
Merged

chore: update ruff config to use lint section#706
abhimehro merged 1 commit into
mainfrom
chore/ruff-config-fix-11248897609115947819

Conversation

@abhimehro

Copy link
Copy Markdown
Owner

This commit updates the .trunk/configs/ruff.toml configuration by migrating the deprecated top-level select and ignore settings into a new [lint] section, eliminating deprecation warnings when running Ruff.


PR created automatically by Jules for task 11248897609115947819 started by @abhimehro

Co-authored-by: abhimehro <84992105+abhimehro@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings April 5, 2026 13:08
@trunk-io

trunk-io Bot commented Apr 5, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No application code in the PR — skipped Code Health checks.

See analysis details in CodeScene

Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s Ruff configuration to the newer schema by moving lint rule configuration under the [lint] table, avoiding deprecation warnings with newer Ruff versions.

Changes:

  • Introduces a [lint] section in .trunk/configs/ruff.toml.
  • Keeps the existing select and ignore rule lists, now correctly scoped under [lint].

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Ruff configuration in .trunk/configs/ruff.toml by adding a [lint] section header. Feedback was provided regarding a significant inconsistency between this configuration and the one defined in pyproject.toml, which could result in different linting outcomes depending on the tool used. It is recommended to synchronize these configurations for consistency.

Comment thread .trunk/configs/ruff.toml
@@ -1,4 +1,5 @@
# Generic, formatter-friendly config.
[lint]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Ruff configuration in this file is significantly inconsistent with the one defined in pyproject.toml. For instance, this file includes flake8-bugbear (B) and pydocstyle (D3, D4) which are absent from pyproject.toml, while pyproject.toml includes several other plugins (W, N, PERF, RET, SIM, UP) that are missing here. This discrepancy can lead to different linting results depending on whether Ruff is invoked via Trunk or directly. Consider synchronizing these configurations to ensure consistent code quality checks across all environments.

@abhimehro
abhimehro merged commit 7d37bd7 into main Apr 6, 2026
17 checks passed
@abhimehro
abhimehro deleted the chore/ruff-config-fix-11248897609115947819 branch April 6, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants