Channel name encoding error for REST requests#119
Conversation
|
pr looks good but travis not happy... these look like the unrelated fails i was seeing on the old pr... need to leave these to you @mattheworiordan i reckon, sorry! |
Good news is that those errors are unrelated and not an issue. One is a test issue introduced by a hotfix ee038c3. The others are errors simply due to the fixtures not working as expected for push notifications and this test suite not supporting push (see #115). So this branch is definitely save for you to use i.e. in your Gemfile I will get this fixed along with the heartbeat issue soon and do a new release. |
|
ah great. i have the 'ably-rest' gem in my bundle here, which doesn't do much beyond bringing this repo in as a submodule. can i just use 'ably-ruby' in my bundle if i'm only using the rest api? |
Yup, you can, you just get a few extra dependencies but it won't make any difference in reality. I'll try and get a release out next week. |
|
awesome, thanks matthew :-) |
Avoids this error when doing ```channel.presence.get``` or ```channel.presence.history```: ``` Addressable::URI::InvalidURIError: Invalid scheme format: 294750 ```
foo:bar was interpreted as a URI with foo being the protocol previously. Addressable.encode_component could have been used (see https://github.com/sporkmonger/addressable/blob/master/lib/addressable/uri.rb#L355), but URI.encode_www_form_component works perfectly and is used elsewhere in the lib.
mattheworiordan
force-pushed
the
presence_error
branch
from
e737229 to
f979c45
Compare
|
This is now merged and available in stable release v1.0.4 |
2 participants
This PR is just @smeyfroi's PR plus one additional test to prevent a regression.