Skip to content

Fallback fixes#120

Merged
mattheworiordan merged 3 commits into
masterfrom
fallback-fixes
May 16, 2017
Merged

Fallback fixes#120
mattheworiordan merged 3 commits into
masterfrom
fallback-fixes

Conversation

@mattheworiordan

Copy link
Copy Markdown
Member

This PR fixes two critical issues:

  • Host header was not being set correctly in fallback hosts over realtime
  • Fallback hosts were being used in all conditions where a transport failed as opposed to only when a connect attempt failed and thus the request was a subsequent attempt to connect to Ably. This issue only existed for realtime connections.

Only use fallback hosts when a connected state is not reached. Previously if a connection became connected then disconnected, a fallback host would be used.  This should only happen if the client is unable to reach a connected state.
@mattheworiordan mattheworiordan merged commit 87dbb7e into master May 16, 2017
@mattheworiordan mattheworiordan deleted the fallback-fixes branch May 16, 2017 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant