Improve pagination history test#138
Merged
Merged
Conversation
mattheworiordan
left a comment
mattheworiordan
left a comment
Member
There was a problem hiding this comment.
This is good 👍
One thing though, it would be nice to add a comment to this test so that future us can understand why we have a conditional statement like this in what should be a deterministic test.
Contributor
Author
|
@mattheworiordan here you go eb729e1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Slack discussion https://ably-real-time.slack.com/archives/C030APSH3/p1524044265000492