Skip to content

New release v1.0.5#142

Merged
funkyboy merged 4 commits into
masterfrom
add-new-release
Apr 23, 2018
Merged

New release v1.0.5#142
funkyboy merged 4 commits into
masterfrom
add-new-release

Conversation

@funkyboy

Copy link
Copy Markdown
Contributor

No description provided.

@funkyboy funkyboy changed the title Bump version New release v1.0.5 Apr 23, 2018
@funkyboy funkyboy requested a review from paddybyers April 23, 2018 14:57

@paddybyers paddybyers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Comment thread CHANGELOG.md

- Add Ruby 2.1 and 2.3 to Travis tests [\#129](https://github.com/ably/ably-ruby/issues/129)
- Add supported platforms to README file [\#128](https://github.com/ably/ably-ruby/issues/128)
- Add Ruby 2.1 and 2.3 to Travis tests [\#130](https://github.com/ably/ably-ruby/pull/130) ([funkyboy](https://github.com/funkyboy))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repetition?

Comment thread CHANGELOG.md Outdated

## [v1.0.1](https://github.com/ably/ably-ruby/tree/v1.0.1) (2017-05-11)
[Full Changelog](https://github.com/ably/ably-ruby/compare/v1.0.0...v1.0.1)
[Full Changelog](https://github.com/ably/ably-ruby/compare/v1.1.0-beta.push.1...v1.0.1)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a diff relative to a beta release?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paddybyers It's something added by https://github.com/github-changelog-generator/github-changelog-generator, which I am guessing wasn't run lately. Want me to delete?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a matter of fact there is such a 1.1.0 release https://github.com/ably/ably-ruby/releases/tag/v1.1.0-beta.push.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point is that the changelog for v1.0.1 should be relative to v1.0.0, not v1.1.0-beta.push.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, fixed 94f95fe

@paddybyers paddybyers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mattheworiordan mattheworiordan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funkyboy funkyboy merged commit 35de00b into master Apr 23, 2018
@funkyboy funkyboy deleted the add-new-release branch April 23, 2018 18:24
@funkyboy funkyboy mentioned this pull request Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants