Skip to content

[EDX-614] Redirect tutorials and client lib development references - #1797

Merged
kennethkalmer merged 3 commits into
mainfrom
EDX-614-redirect-tutorials-and-client-lib-development-references
Dec 6, 2022
Merged

[EDX-614] Redirect tutorials and client lib development references#1797
kennethkalmer merged 3 commits into
mainfrom
EDX-614-redirect-tutorials-and-client-lib-development-references

Conversation

@kennethkalmer

@kennethkalmer kennethkalmer commented Dec 6, 2022

Copy link
Copy Markdown
Member

NOTE TO REVIEWERS - please do not review PRs in the DRAFT state, as the PR may change substantially before it is ready to review. Thanks.

Description

Now that the new toolchain is available on docs.ably.com as well, we have some old nanoc toolchain artefacts to deal with as well:

See EDX-614

This also addresses these comments from @m-hulbert & @QuintinWillison in #1608

Any objections if we get redirects set up with the web team in the future to remove these pages from docs entirely? Do we need to preserve the deep links of the features spec for anything?

I would love for that to happen and I had presumed that this would be the next logical step, after this pull request has landed. My intention here was to get the 'soft redirects' in place. What I would want to see from future redirects, of course, is that they also carry over the HTML element id anchors too. Some of these documents are quite long and that was one of my goals, to keep that rich, deep linking carrying forwards.

Review

Testing is quite simple on the review app

Visiting https://ably-docs-edx-614-redir-vohrir.herokuapp.com/tutorials should redirect to ably.com/tutorials
Visiting https://ably-docs-edx-614-redir-vohrir.herokuapp.com/client-lib-development-guide should redirect to sdk.ably.com (as per #1608)

@ably-ci
ably-ci temporarily deployed to ably-docs-edx-614-redir-vohrir December 6, 2022 12:41 Inactive
@kennethkalmer kennethkalmer self-assigned this Dec 6, 2022

@MymmiJ MymmiJ left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@kennethkalmer
kennethkalmer merged commit c13c455 into main Dec 6, 2022
@kennethkalmer
kennethkalmer deleted the EDX-614-redirect-tutorials-and-client-lib-development-references branch December 6, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants