Chat constants reload by AndyTWF · Pull Request #2455 · ably/docs

AndyTWF · 2025-02-27T15:26:03Z

Context

Description

This pull request includes several updates to the content/chat/rooms/index.textile and content/chat/setup.textile files to replace the usage of RoomOptionsDefaults with AllFeaturesEnabled and to add ChatClientOptions references for better understandability.

coderabbitai · 2025-02-27T15:26:12Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

AndyTWF · 2025-02-27T15:32:25Z

Moving back to draft until the library is ready for release - but please still review it!

AndyTWF · 2025-03-11T13:54:17Z

Im putting together an integration branch for everything related to chat-js 0.5.0 to save endless rebasing, please review :)

Fix formatting for links

…cs-broken Fix bug where support link goes to /docs/support

Local implementation of compile-time feature flags like we added in ably/ably-ui#650

[WEB-4265] Add support for Ably Insights

Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.24.0 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers) --- updated-dependencies: - dependency-name: "@babel/helpers" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…ers-7.26.10 chore(deps): bump @babel/helpers from 7.24.0 to 7.26.10

vladvelici

👍

Just a minor comment

content/chat/setup.textile

* Fix incorrect links in content docs * Fix bug where support link goes to /docs/support * feat: initial ably-ui insights setup * refactor: consolidate SessionState types into a single one * cleanup: externalScriptsData doesn't change at runtime * feat: compile-time feature flags like ably-ui Local implementation of compile-time feature flags like we added in ably/ably-ui#650 * cleanup: remove unused GTM trackPageView function * chore(deps): bump @babel/helpers from 7.24.0 to 7.26.10 Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.24.0 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers) --- updated-dependencies: - dependency-name: "@babel/helpers" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * chat: update message version comparison function names (#2462) * chat: add JS message copying and update signature (#2470) * chat/js: rename DefaultRoomOptions to AllFeaturesEnabled * chat/js: make explicit reference to client options --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com> Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com> Co-authored-by: Greg Holmes <iam@gregholmes.co.uk> Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chat: update message version comparison function names (#2462) * chat: add JS message copying and update signature (#2470) * Chat constants reload (#2455) * Fix incorrect links in content docs * Fix bug where support link goes to /docs/support * feat: initial ably-ui insights setup * refactor: consolidate SessionState types into a single one * cleanup: externalScriptsData doesn't change at runtime * feat: compile-time feature flags like ably-ui Local implementation of compile-time feature flags like we added in ably/ably-ui#650 * cleanup: remove unused GTM trackPageView function * chore(deps): bump @babel/helpers from 7.24.0 to 7.26.10 Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.24.0 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers) --- updated-dependencies: - dependency-name: "@babel/helpers" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * chat: update message version comparison function names (#2462) * chat: add JS message copying and update signature (#2470) * chat/js: rename DefaultRoomOptions to AllFeaturesEnabled * chat/js: make explicit reference to client options --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com> Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com> Co-authored-by: Greg Holmes <iam@gregholmes.co.uk> Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chat: bump to 0.5 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com> Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com> Co-authored-by: Greg Holmes <iam@gregholmes.co.uk> Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ably-ci temporarily deployed to ably-docs-chat-constant-uxy140 February 27, 2025 15:26 Inactive

AndyTWF requested review from splindsay-92 and vladvelici February 27, 2025 15:27

AndyTWF mentioned this pull request Feb 27, 2025

Renaming types for clarity ably/ably-chat-js#478

Merged

8 tasks

AndyTWF requested a review from a team February 27, 2025 15:28

AndyTWF marked this pull request as draft February 27, 2025 15:32

AndyTWF force-pushed the chat-constants-reload branch from e2f0ab3 to 29dbdb7 Compare February 27, 2025 15:37

vladvelici mentioned this pull request Feb 27, 2025

Rename Chat constant RoomOptionsDefault -> DefaultRoomOptions #2418

Closed

AndyTWF changed the base branch from main to integration/chat-js-0.5.0 March 11, 2025 13:53

AndyTWF marked this pull request as ready for review March 11, 2025 13:53

VeskeR and others added 12 commits March 12, 2025 09:52

Fix incorrect links in content docs

4a20b80

Merge pull request #2469 from ably/fix-links

c168730

Fix formatting for links

Fix bug where support link goes to /docs/support

b6e978e

Merge pull request #2472 from ably/EDU-1841-support-link-at-top-of-do…

42a675e

…cs-broken Fix bug where support link goes to /docs/support

feat: initial ably-ui insights setup

1a8cfd7

refactor: consolidate SessionState types into a single one

33ae81d

cleanup: externalScriptsData doesn't change at runtime

41a762e

feat: compile-time feature flags like ably-ui

2281482

Local implementation of compile-time feature flags like we added in ably/ably-ui#650

cleanup: remove unused GTM trackPageView function

abcc30a

Merge pull request #2468 from ably/WEB-4265-ably-insights

89396dd

[WEB-4265] Add support for Ably Insights

Merge pull request #2476 from ably/dependabot/npm_and_yarn/babel/help…

688acf5

…ers-7.26.10 chore(deps): bump @babel/helpers from 7.24.0 to 7.26.10

vladvelici approved these changes Mar 12, 2025

View reviewed changes

content/chat/setup.textile Outdated Show resolved Hide resolved

AndyTWF added 4 commits March 12, 2025 14:25

chat: update message version comparison function names (#2462)

dc15154

chat: add JS message copying and update signature (#2470)

39152ca

chat/js: rename DefaultRoomOptions to AllFeaturesEnabled

8b6b9e6

chat/js: make explicit reference to client options

ae50b58

AndyTWF force-pushed the chat-constants-reload branch from 29dbdb7 to ae50b58 Compare March 12, 2025 14:25

GregHolmes approved these changes Mar 12, 2025

View reviewed changes

AndyTWF merged commit 5ef1e83 into integration/chat-js-0.5.0 Mar 12, 2025
5 checks passed

AndyTWF deleted the chat-constants-reload branch March 12, 2025 14:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chat constants reload#2455

Chat constants reload#2455
AndyTWF merged 16 commits intointegration/chat-js-0.5.0from
chat-constants-reload

AndyTWF commented Feb 27, 2025 •

edited by atlassian bot

Loading

Uh oh!

coderabbitai bot commented Feb 27, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

AndyTWF commented Feb 27, 2025

Uh oh!

AndyTWF commented Mar 11, 2025

Uh oh!

vladvelici left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

Conversation

AndyTWF commented Feb 27, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Description

Uh oh!

coderabbitai bot commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

AndyTWF commented Feb 27, 2025

Uh oh!

AndyTWF commented Mar 11, 2025

Uh oh!

vladvelici left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

AndyTWF commented Feb 27, 2025 •

edited by atlassian bot

Loading

coderabbitai bot commented Feb 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)