Skip to content

chat: update message version comparison function names#2462

Merged
AndyTWF merged 1 commit intointegration/chat-js-0.5.0from
chat-message-version-helpers
Mar 11, 2025
Merged

chat: update message version comparison function names#2462
AndyTWF merged 1 commit intointegration/chat-js-0.5.0from
chat-message-version-helpers

Conversation

@AndyTWF
Copy link
Contributor

@AndyTWF AndyTWF commented Mar 4, 2025

Description

Updates the version comparison function names for messages.

Per: ably/ably-chat-js#479

Checklist

@AndyTWF AndyTWF requested a review from vladvelici March 4, 2025 12:41
@coderabbitai
Copy link

coderabbitai bot commented Mar 4, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ably-ci ably-ci temporarily deployed to ably-docs-chat-message--lk6rwj March 4, 2025 12:41 Inactive
@AndyTWF AndyTWF force-pushed the chat-message-version-helpers branch from f55479e to c13a4fc Compare March 4, 2025 13:28
@AndyTWF AndyTWF changed the base branch from main to integration/chat-js-0.5.0 March 11, 2025 13:55
@AndyTWF AndyTWF marked this pull request as ready for review March 11, 2025 13:55
@AndyTWF
Copy link
Contributor Author

AndyTWF commented Mar 11, 2025

@vladvelici I've made this ready for review as I've created an integration branch to squash into

@AndyTWF AndyTWF merged commit b3c6702 into integration/chat-js-0.5.0 Mar 11, 2025
5 checks passed
@AndyTWF AndyTWF deleted the chat-message-version-helpers branch March 11, 2025 13:58
AndyTWF added a commit that referenced this pull request Mar 12, 2025
* Fix incorrect links in content docs

* Fix bug where support link goes to /docs/support

* feat: initial ably-ui insights setup

* refactor: consolidate SessionState types into a single one

* cleanup: externalScriptsData doesn't change at runtime

* feat: compile-time feature flags like ably-ui

Local implementation of compile-time feature flags like we added in
ably/ably-ui#650

* cleanup: remove unused GTM trackPageView function

* chore(deps): bump @babel/helpers from 7.24.0 to 7.26.10

Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.24.0 to 7.26.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers)

---
updated-dependencies:
- dependency-name: "@babel/helpers"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chat: update message version comparison function names (#2462)

* chat: add JS message copying and update signature (#2470)

* chat/js: rename DefaultRoomOptions to AllFeaturesEnabled

* chat/js: make explicit reference to client options

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Greg Holmes <iam@gregholmes.co.uk>
Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AndyTWF added a commit that referenced this pull request Mar 12, 2025
* Fix incorrect links in content docs

* Fix bug where support link goes to /docs/support

* feat: initial ably-ui insights setup

* refactor: consolidate SessionState types into a single one

* cleanup: externalScriptsData doesn't change at runtime

* feat: compile-time feature flags like ably-ui

Local implementation of compile-time feature flags like we added in
ably/ably-ui#650

* cleanup: remove unused GTM trackPageView function

* chore(deps): bump @babel/helpers from 7.24.0 to 7.26.10

Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.24.0 to 7.26.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers)

---
updated-dependencies:
- dependency-name: "@babel/helpers"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chat: update message version comparison function names (#2462)

* chat: add JS message copying and update signature (#2470)

* chat/js: rename DefaultRoomOptions to AllFeaturesEnabled

* chat/js: make explicit reference to client options

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Greg Holmes <iam@gregholmes.co.uk>
Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AndyTWF added a commit that referenced this pull request Mar 14, 2025
* Fix incorrect links in content docs

* Fix bug where support link goes to /docs/support

* feat: initial ably-ui insights setup

* refactor: consolidate SessionState types into a single one

* cleanup: externalScriptsData doesn't change at runtime

* feat: compile-time feature flags like ably-ui

Local implementation of compile-time feature flags like we added in
ably/ably-ui#650

* cleanup: remove unused GTM trackPageView function

* chore(deps): bump @babel/helpers from 7.24.0 to 7.26.10

Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.24.0 to 7.26.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers)

---
updated-dependencies:
- dependency-name: "@babel/helpers"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chat: update message version comparison function names (#2462)

* chat: add JS message copying and update signature (#2470)

* chat/js: rename DefaultRoomOptions to AllFeaturesEnabled

* chat/js: make explicit reference to client options

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Greg Holmes <iam@gregholmes.co.uk>
Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AndyTWF added a commit that referenced this pull request Mar 14, 2025
* Fix incorrect links in content docs

* Fix bug where support link goes to /docs/support

* feat: initial ably-ui insights setup

* refactor: consolidate SessionState types into a single one

* cleanup: externalScriptsData doesn't change at runtime

* feat: compile-time feature flags like ably-ui

Local implementation of compile-time feature flags like we added in
ably/ably-ui#650

* cleanup: remove unused GTM trackPageView function

* chore(deps): bump @babel/helpers from 7.24.0 to 7.26.10

Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.24.0 to 7.26.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers)

---
updated-dependencies:
- dependency-name: "@babel/helpers"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chat: update message version comparison function names (#2462)

* chat: add JS message copying and update signature (#2470)

* chat/js: rename DefaultRoomOptions to AllFeaturesEnabled

* chat/js: make explicit reference to client options

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Greg Holmes <iam@gregholmes.co.uk>
Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AndyTWF added a commit that referenced this pull request Mar 14, 2025
* chat: update message version comparison function names (#2462)

* chat: add JS message copying and update signature (#2470)

* Chat constants reload (#2455)

* Fix incorrect links in content docs

* Fix bug where support link goes to /docs/support

* feat: initial ably-ui insights setup

* refactor: consolidate SessionState types into a single one

* cleanup: externalScriptsData doesn't change at runtime

* feat: compile-time feature flags like ably-ui

Local implementation of compile-time feature flags like we added in
ably/ably-ui#650

* cleanup: remove unused GTM trackPageView function

* chore(deps): bump @babel/helpers from 7.24.0 to 7.26.10

Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.24.0 to 7.26.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers)

---
updated-dependencies:
- dependency-name: "@babel/helpers"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chat: update message version comparison function names (#2462)

* chat: add JS message copying and update signature (#2470)

* chat/js: rename DefaultRoomOptions to AllFeaturesEnabled

* chat/js: make explicit reference to client options

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Greg Holmes <iam@gregholmes.co.uk>
Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chat: bump to 0.5

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Greg Holmes <iam@gregholmes.co.uk>
Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
owenpearson pushed a commit that referenced this pull request Mar 19, 2025
* chat: update message version comparison function names (#2462)

* chat: add JS message copying and update signature (#2470)

* Chat constants reload (#2455)

* Fix incorrect links in content docs

* Fix bug where support link goes to /docs/support

* feat: initial ably-ui insights setup

* refactor: consolidate SessionState types into a single one

* cleanup: externalScriptsData doesn't change at runtime

* feat: compile-time feature flags like ably-ui

Local implementation of compile-time feature flags like we added in
ably/ably-ui#650

* cleanup: remove unused GTM trackPageView function

* chore(deps): bump @babel/helpers from 7.24.0 to 7.26.10

Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.24.0 to 7.26.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers)

---
updated-dependencies:
- dependency-name: "@babel/helpers"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chat: update message version comparison function names (#2462)

* chat: add JS message copying and update signature (#2470)

* chat/js: rename DefaultRoomOptions to AllFeaturesEnabled

* chat/js: make explicit reference to client options

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Greg Holmes <iam@gregholmes.co.uk>
Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chat: bump to 0.5

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Greg Holmes <iam@gregholmes.co.uk>
Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
owenpearson pushed a commit that referenced this pull request Mar 19, 2025
* chat: update message version comparison function names (#2462)

* chat: add JS message copying and update signature (#2470)

* Chat constants reload (#2455)

* Fix incorrect links in content docs

* Fix bug where support link goes to /docs/support

* feat: initial ably-ui insights setup

* refactor: consolidate SessionState types into a single one

* cleanup: externalScriptsData doesn't change at runtime

* feat: compile-time feature flags like ably-ui

Local implementation of compile-time feature flags like we added in
ably/ably-ui#650

* cleanup: remove unused GTM trackPageView function

* chore(deps): bump @babel/helpers from 7.24.0 to 7.26.10

Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.24.0 to 7.26.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers)

---
updated-dependencies:
- dependency-name: "@babel/helpers"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chat: update message version comparison function names (#2462)

* chat: add JS message copying and update signature (#2470)

* chat/js: rename DefaultRoomOptions to AllFeaturesEnabled

* chat/js: make explicit reference to client options

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Greg Holmes <iam@gregholmes.co.uk>
Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chat: bump to 0.5

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Greg Holmes <iam@gregholmes.co.uk>
Co-authored-by: Kenneth Kalmer <kenneth.kalmer@ably.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants