Skip to content

Build textile to html - #4

Merged
QuintinWillison merged 17 commits into
mainfrom
build-textile-to-html
Oct 4, 2022
Merged

Build textile to html#4
QuintinWillison merged 17 commits into
mainfrom
build-textile-to-html

Conversation

@QuintinWillison

@QuintinWillison QuintinWillison commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

We need the Textile source files rendered for preview and consumption by client library developers.

For the time being I've made the decision not to convert any of the textile files to a more modern and friendly format like markdown. This is mainly because it's useful to keep the rich Git commit history currently visible against the textile files (as duplicated over from the ably/docs repository).

I'm also trying to keep this build as simple and self-contained as possible, with minimal reliance on bigger frameworks or many other dependencies. Therefore, pulling this together with just a basic Handlebars implementation fed with output from Redcloth feels appropriate and maintainable. Plus, Tailwind CSS for styling, which is most sensibly deployed natively using Node.js - so, using npm to run things, which makes sense (calling down to Ruby scripts when required).

Use the View deployment button on this pull request to see the rendered result.

@QuintinWillison QuintinWillison self-assigned this Sep 26, 2022
@QuintinWillison

QuintinWillison commented Sep 26, 2022

Copy link
Copy Markdown
Contributor Author

Obsolete Comment: The failure of the 'Assemble' workflow is expected. I will run it again once we've release v2 of the SDK Upload Action, which will include ably/sdk-upload-action#46.

Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
@github-actions
github-actions Bot temporarily deployed to production September 27, 2022 10:30 Inactive
@github-actions
github-actions Bot temporarily deployed to production September 27, 2022 10:38 Inactive
@github-actions
github-actions Bot temporarily deployed to staging/pull/4 September 27, 2022 10:59 Inactive
@github-actions
github-actions Bot temporarily deployed to staging/pull/4 September 27, 2022 15:27 Inactive
@github-actions
github-actions Bot temporarily deployed to staging/pull/4 October 2, 2022 14:34 Inactive
I'm intentionally leaving the layout otherwise fully fluid.
There is no need for an arbitrary limit to rendering width, as most users of this kind of documentation will prefer to size their browser view of this content to a width that works for them.
@github-actions
github-actions Bot temporarily deployed to staging/pull/4 October 2, 2022 15:03 Inactive
@github-actions
github-actions Bot temporarily deployed to staging/pull/4 October 2, 2022 15:32 Inactive
@github-actions
github-actions Bot temporarily deployed to staging/pull/4 October 2, 2022 17:08 Inactive
That was fun... one side effect was for lists - each item was starting a brand new list in HTML form.
@github-actions
github-actions Bot temporarily deployed to staging/pull/4 October 2, 2022 17:28 Inactive
@github-actions
github-actions Bot temporarily deployed to staging/pull/4 October 2, 2022 17:42 Inactive

@stmoreau stmoreau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice one!

# Conflicts:
#	.tool-versions
@QuintinWillison
QuintinWillison merged commit 22e5f01 into main Oct 4, 2022
@QuintinWillison
QuintinWillison deleted the build-textile-to-html branch October 4, 2022 10:48
SimonWoolf pushed a commit that referenced this pull request Jan 6, 2025
[EDX-168] - Channel class descriptions
ttypic pushed a commit that referenced this pull request Mar 6, 2026
ttypic pushed a commit that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants