Convert Firefox artifacts to LAVA (@artifact_processor)#722
Merged
Conversation
Convert six single-report Firefox artifacts to the LAVA output pipeline: firefoxCookies, firefoxDownloads, firefoxFormHistory, firefoxPermissions, firefoxRecentlyClosedTabs, firefoxTopSites. Each now uses @artifact_processor and returns (data_headers, data_list, source_path), adding LAVA output alongside the existing HTML/TSV/timeline. SQL queries and row extraction are unchanged; datetime columns are marked with the 'datetime' type and output_types is "standard". The function key is dropped since decorated functions resolve by name. Deferred: firefox (multi-report, 4 tables).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts six single-report Firefox artifacts to the LAVA output pipeline:
Each now uses
@artifact_processorand returns(data_headers, data_list, source_path), adding LAVA output alongside the existing HTML/TSV/timeline. The SQL queries and row extraction are unchanged from the previous versions (verified structurally againstmain); datetime columns are marked with the'datetime'type andoutput_typesis"standard". The redundant"function"key is dropped since decorated functions resolve by name.Deferred to a later PR:
firefox(multi-report — 4 tables).Verified: all six parse, are lint-clean, the plugin loader resolves them with no warnings, and their SQL queries / data rows match the pre-conversion versions.