Convert vault/locker and Cash App artifacts to LAVA (@artifact_processor)#724
Merged
Conversation
…sor) Convert four single-report artifacts to the LAVA output pipeline: vaulty_files, appLockerfishingnetdb, appLockerfishingnetpat, cashApp. Each now uses @artifact_processor and returns (data_headers, data_list, source_path), adding LAVA output alongside the existing HTML/TSV (and timeline for cashApp, which has a datetime column). Queries and row extraction are unchanged. Details: - vaulty_files: datetime columns marked; the research-URL note moved into the header description. - appLockerfishingnetdb / appLockerfishingnetpat: dropped the old html_no_escape=['Media'] flag (referenced a non-existent column). - cashApp: marks Transaction Date as 'datetime'; the pre-existing process-last-.db-file structure is left as-is. Deferred: vaulty_info has a pre-existing Python 3.9+ crash (base64.decodestring was removed) that should be fixed as a bug before conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts four single-report artifacts to the LAVA output pipeline:
Each now uses
@artifact_processorand returns(data_headers, data_list, source_path), adding LAVA output alongside the existing HTML/TSV (and timeline forcashApp, which has a datetime column). Queries and row extraction are unchanged (verified structurally againstmain).Notes:
vaulty_files: datetime columns marked; the research-URL note moved into the headerdescription.appLockerfishingnetdb/appLockerfishingnetpat: dropped the oldhtml_no_escape=['Media']flag, which referenced a non-existent column.cashApp: marksTransaction Dateas'datetime'; the pre-existing process-last-.db-file structure is preserved.Deferred:
vaulty_info(same Vaulty app) has a pre-existing Python 3.9+ crash —base64.decodestringwas removed from the stdlib — so it should be fixed as a bug before being converted.Verified: all four parse, are lint-clean, the plugin loader resolves them with no warnings, and their queries /
data_listrows match the pre-conversion versions. (No test data for these apps in available extractions; structural-gate conversion.)