Fix LAVA timestamps for the Chrome family (tz-aware UTC)#739
Merged
Conversation
The Chrome artifacts fed naive datetimes to their 'datetime' columns, so the LAVA epoch was shifted by the report machine's timezone (both the per-browser tables and the combined output). Make them tz-aware: - chromeBookmarks built a naive datetime object (datetime(1601,1,1)+timedelta); add tzinfo=timezone.utc so it is UTC-aware. - chromeCookies (3 cols), chromeOfflinePages (2), chromeLoginData (1), chromeMediaHistory Sessions/Playbacks/Origins (1 each): wrap the SQL datetime strings with convert_human_ts_to_utc. HTML/TSV now show explicit UTC; no query changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the LAVA epoch for the Chrome family's
datetimecolumns (they were fed naive datetimes, so the stored epoch was shifted by the report machine's timezone — affecting both the per-browser tables and the combined output).datetime(1601,1,1)+timedelta); nowtzinfo=timezone.utcmakes it UTC-aware.datetime(...)strings withconvert_human_ts_to_utc.No query changes; HTML/TSV now show explicit UTC (
+00:00), consistent with iLEAPP.Verified: all parse, lint-clean, loader resolves with no warnings; the conversion was confirmed to produce the correct UTC epoch.