Convert Skype to LAVA (multi-report split)#742
Merged
Merged
Conversation
Split into get_skype_call_logs, get_skype_messages, get_skype_contacts, each reading the live db via a shared _skype_db helper. Datetime columns use the tz-aware datetime.fromtimestamp(ts, timezone.utc) form (replacing the deprecated utcfromtimestamp), so LAVA stores correct epochs. Queries are unchanged; a dead user-table query (its result was never used) is dropped. Function key removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits Skype into one
@artifact_processorfunction per table:get_skype_call_logsget_skype_messagesget_skype_contactsAll read the
livedb via a shared_skype_dbhelper. Datetime columns use the tz-awaredatetime.fromtimestamp(ts, timezone.utc)form (replacing the deprecatedutcfromtimestamp), so LAVA stores correct epochs. Queries are unchanged; a dead user-table query (its result was never used in any report) is dropped.Deferred:
googleDuo— its "Notes" sub-report copies media files and embeds<img>thumbnails, so it belongs in the media-handling pass.Verified: parses, lint-clean, the plugin loader resolves all three functions with no warnings.