Convert chrome.py to LAVA @artifact_processor (multi-browser)#769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the core Chromium History parser to the LAVA
@artifact_processorpattern, following the established multi-browser approach (per-browser HTML report + per-browser LAVA table + combined return with aBrowser Namediscriminator column).Split the single old
get_chromeinto five decorated artifacts, one per report:last_access_time/tab_urlschema probes for older DB versions)Timestamps: replaced all in-SQL
datetime(col/1000000 + strftime('%s','1601-01-01'),'unixepoch')WebKit conversions with raw column selection + a Python_webkit_to_utchelper returning tz-aware UTC datetimes (anchored 1601-01-01 UTC, 0/NULL → ''); the relevant timestamp columns are markeddatetimein LAVA.get_browser_nameis kept byte-for-byte identical (verified for Brave/Edge/Opera/Chrome/webview/Unknown), and the modules that import it (chromeDIPS, chromeAutofill, chromeBookmarks, etc.) still load.Verified: byte-compile, all 5 functions decorated with 4-arg signature, return 3-tuples, output_types valid, loader resolves all, get_browser_name behavior preserved + importers load, pylint clean.