Convert GarminChart to LAVA @artifact_processor#777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of the tractable Garmin artifacts.
activity_detailsjoined toactivity_chart_data. Replaced the in-SQLdatetime(...,'unixepoch')conversions with raw epoch selection + Python aware-UTC;Activity Last UpdatedandChart Last Updatedmarkeddatetime.createLineChartbutton built from the chart series — that's HTML-report-only. Replaced it with the actualchartXListandchartYListvalues as their own columns, so the chart data is preserved in LAVA instead of a non-functional button. Droppedadd_chart/filter_by_date.Remaining Garmin (
GarminPolyline,GarminPolyAPI,GarminFacebook) are the genuine GIS-map / live-network tier and are intentionally left for separate handling.Verified: byte-compile, decorated 4-arg signature, returns 3-tuple, output_types valid, loader builds (407 plugins), pylint clean.