Convert smyFiles to LAVA @artifact_processor (multi-report)#791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the Samsung My Files DB parser into three decorated artifacts with distinct names (the original gave its two download-history reports the same title, and its recent-files report would have collided with the already-converted smyfilesRecents 'My Files - Recent Files'):
download_history(mDate schema)download_history(pre-Android 12dateschema)recent_files(mDate schema)All timestamps converted from epoch-ms to aware UTC
datetime(replacing SQLdatetime(...,'unixepoch')). Each query is wrapped (one schema variant succeeds per DB version); shared_myfiles_db/_queryhelpers; bareexceptnarrowed toException+ logfunc.Verified: byte-compile, all 3 decorated 4-arg, return 3-tuples, no duplicate artifact names anywhere in the repo, CI-style pylint 0 W/E, loader builds (419).