Convert offlinePages to LAVA @artifact_processor (+ media migration)#811
Merged
Conversation
Converts the MHTML/MHT offline-page parser to the decorated single-return
pattern and migrates the file column from the legacy media_to_html to a
proper ('File','media') column backed by check_in_media, so the archive
is registered in the LAVA media store. Timestamp is an aware UTC datetime
(drops the no-op pytz/UTC->UTC conversion). Renames the artifact from the
generic 'pages' to 'Offline Pages (MHTML)' (the name 'Offline Pages' is
taken by chromeOfflinePages) and replaces the stale description. Adds
encoding= to open() for the W1514 lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
offlinePages.py(MHTML/MHT saved offline pages) to the decorated@artifact_processorpattern.Changes
Filecolumn moves from legacymedia_to_htmlto a proper('File','media')column backed bycheck_in_media, so each archive is registered in the LAVA media store (refs/dedupe; exports get a path instead of an HTML snippet). First of themedia_to_htmlmigrations tracked from the media discussion.Timestampis now an aware UTCdatetime(drops the no-op pytz UTC→UTC conversion).pagesto Offline Pages (MHTML) —Offline Pagesis already used bychromeOfflinePages(category Chromium); this one keeps category Offline Pages.encoding=added toopen()for W1514.Original
creation_date/last_update_date(2023-01-25) preserved.