Convert torThumbs to LAVA @artifact_processor (+ media migration)#814
Merged
Conversation
Converts the Tor Browser thumbnail parser to the decorated single-return
pattern. The .0 thumbnail files are extensionless image blobs, so decode
each to PNG bytes and register via check_in_embedded_media with a
('Thumbnail','media') column (replacing media_to_html + a loose PNG saved
into the report folder and the Windows '?'-strip hack). Modified time is
now an aware UTC datetime, and Image.open is guarded so a non-image file
is skipped rather than crashing the artifact. Renames the artifact from
'torThumbs' to 'TOR Thumbnails'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
torThumbs.py(Tor Browser cached page thumbnails) to the decorated@artifact_processorpattern.Changes
.0thumbnail files are extensionless image blobs, so each is decoded to PNG bytes and registered viacheck_in_embedded_mediainto a('Thumbnail','media')column — same approach as SamsungHoneyboard. Replacesmedia_to_html+ a loose PNG written into the report folder and the Windows?-strip hack.Modified Timeis now an aware UTCdatetime.Image.openis guarded — a non-image file is logged and skipped instead of crashing the artifact.torThumbs→ TOR Thumbnails.Original
creation_date/last_update_date(2021-12-23) preserved.