Convert imagemngCache to LAVA @artifact_processor (+ media migration)#816
Merged
Conversation
Converts the Glide image_manager_disk_cache / .cnt cache parser to the
decorated single-return pattern. Migrates the media column from
media_to_html to ('Media','media') backed by check_in_media (the cache
files are raw image bytes under hash names; check_in_media auto-detects
the MIME from the bytes). Timestamp Last Modified is now an aware UTC
datetime. Replaces the junk name 'ImagemngCache' / description 'else:'
with proper values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
imagemngCache.py(Glideimage_manager_disk_cacheand.cntimage caches) to the decorated@artifact_processorpattern.Changes
media_to_htmlto('Media','media')backed bycheck_in_media. These cache files are raw image bytes stored under hash names, socheck_in_mediaauto-detects the MIME/extension from the bytes (no PIL needed).Timestamp Last Modifiedis now an aware UTCdatetime.name(ImagemngCache) anddescription(else:, a stray code comment) with real values.Original
creation_date/last_update_date(2022-03-05) preserved.