Convert smyfilescache to LAVA @artifact_processor (+ media migration)#818
Merged
Conversation
Converts the Samsung My Files FileCache.db parser to the decorated
single-return pattern. The original ran two schema queries back to back
(date_modified/_data vs date/path) emitting the same report twice if both
matched; this now tries the variants in order and uses the first that
succeeds. Thumbnail column migrates from media_to_html to ('Media','media')
backed by check_in_media, resolving each {_index}.jpg against the cache
files. Timestamp Modified and Latest are now aware UTC datetimes. Adds a
guard so a missing FileCache.db no longer falls through to opening a cache
jpg as a database. Renames artifact 'smyfilescache' -> 'My Files Cache'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
smyfilescache.py(Samsung My FilesFileCache.db) to the decorated@artifact_processorpattern.Changes
date_modified/_datathendate/path) and emitted the same report for each that succeeded — a duplicate if both columns existed. Now tries the variants in order and uses the first that works.media_to_htmlto('Media','media')backed bycheck_in_media, resolving each{_index}.jpgagainst the cache files in the extraction.Timestamp ModifiedandLatestare now aware UTCdatetimevalues.FileCache.dbis present, the artifact no longer falls through toopen_sqlite_db_readonlyon a cache.jpg(the old loop leftfile_foundpointing at the last file).smyfilescache→ My Files Cache (parallelsMy Files Trash).Original
creation_date/last_update_date(2022-06-23) preserved.