Convert NQ_Vault to LAVA @artifact_processor (2-way split + media migration)#822
Merged
Conversation
…ration)
Splits the NQ Vault (com.netqin.ps) parser into two decorated artifacts
under 'Encrypting Media Apps' (was 'Encrypting Media apps'): Decrypted PINs
and Decrypted Media. brute_force_pin is now memoized with lru_cache so the
split doesn't run the (potentially slow) PIN brute force twice. The XOR-
decrypted media bytes are registered via check_in_embedded_media into a
('Media','media') column, dropping the ~30 lines of safe-output-path /
file-writing helpers (the media store handles storage). Timestamp is now
an aware UTC datetime (query selects raw epoch ms instead of a SQLite
DATETIME string). XOR decryption rewritten as a single bytes comprehension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
NQ_Vault.py(NQ Vault / com.netqin.ps) to the decorated@artifact_processorpattern, split into two artifacts under Encrypting Media Apps (wasEncrypting Media apps— capitalization consolidated):get_NQVaultget_NQVault_mediaChanges
functools.lru_cache— the original ran it once; the two-function split would otherwise run it twice, so caching keeps the (potentially very slow) 3–15 digit brute force to a single pass per encoded PIN. Verified:java_string_hashcode('1234') == 1509442.check_in_embedded_mediainto a('Media','media')column. This drops ~30 lines ofsanitize_output_filename/build_safe_output_path/file-writing — the LAVA media store handles storage and naming, so the path-traversal guards are no longer needed.Timestampis now an aware UTCdatetime(query selects raw epoch ms instead of a SQLiteDATETIME()string).Original dates (2023-05-19) preserved. Third of the encrypting-vault apps (after Playground #820, App Locker #821).