Convert browserCachechrome to LAVA @artifact_processor (+ media migration)#824
Merged
Conversation
…tion)
Converts the Chrome disk-cache (*_0) parser to the decorated single-return
pattern. The cache body (unwrapped from the header/URL/EOF-marker envelope,
and gunzipped when x-gzip) is registered via check_in_embedded_media into a
('Cached File','media') column instead of being written to the report
folder + media_to_html. Gzip is now decompressed in memory. Timestamp
Modified is an aware UTC datetime. Drops a no-op bug ('if is_platform_windows:'
tested the function object, always truthy) and the dead email import.
Renames 'browserCachechrome' -> 'Chrome Browser Cache'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
browserCachechrome.py(Chrome disk cache*_0entries) to the decorated@artifact_processorpattern.Changes
x-gzip— is registered viacheck_in_embedded_mediainto a('Cached File','media')column (with the guessed MIME/extension), instead of being written to the report folder +media_to_html. Gzip is now decompressed in memory.Timestamp Modified→ aware UTCdatetime.if is_platform_windows:tested the function object (always truthy), so the/?-strip always ran; removed along with the deademailimport.browserCachechrome→ Chrome Browser Cache.Original dates (2023-01-28) preserved. Firefox sibling (
browserCachefirefox) coming next.