Migrate 4 artifacts off legacy media_to_html to check_in_media#836
Merged
Conversation
…_to_html
These four artifacts were already @artifact_processor-decorated but still
rendered media via the legacy media_to_html helper (which stores raw HTML
in the LAVA cell). Swaps each media column to a proper ('media') column
backed by check_in_media:
- SamsungNotes: note media list (drops the manual html_columns).
- FairEmail: attachments list + message-body Content.
- RandoChat: message Media File.
- gmailIMAPEmails: attachments as a flat list of refs, preserving each
attachment's filename as the media name.
The now-unused report_folder params are underscored to avoid W0613. No
behaviour change beyond proper LAVA media handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four artifacts were already
@artifact_processor-decorated but still rendered media through the legacymedia_to_htmlhelper, which stores raw HTML in the LAVA cell (bypassing the media store). This swaps each to a proper('media')column backed bycheck_in_media:SamsungNotesMedia(also drops the manualhtml_columns)FairEmailAttachments(list) +Content(message body)RandoChatMedia FilegmailIMAPEmailsAttachments— flat list of refs, with each attachment's filename preserved as the media nameThe now-unused
report_folderparameters are underscored to avoidW0613. All four are lint-clean and reserved-word-audited.This completes the clean part of the media migration. Remaining
media_to_htmlusers are either dead imports in files with heavy pre-existing lint debt (DuckDuckGo, ProtonDrive, gmailEmails — left alone) or the polymorphicclipBoardData column (needs a column redesign).