Convert googleMapsSearches to LAVA @artifact_processor (+ bug fix)#848
Merged
Conversation
Converts the Google Maps recent-search protobuf cache parser to the decorated single-return pattern. Consolidates the per-file dynamically- named reports into one fixed-name table; KML retained via output_types 'all'. The duplicated list/dict extraction is refactored into one helper, fixing a latent NameError where the dict branch referenced 'things' (the list branch's loop variable). Microsecond search timestamp becomes an aware UTC datetime. Protobuf typedef preserved verbatim; decode wrapped so a malformed cache is skipped rather than crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
googleMapsSearches.py(Google Maps recent-search protobuf cache) to the decorated@artifact_processorpattern.Changes
- {counter}) reports into one fixed-name Google Maps Searches table; KML retained (output_types: all) — Latitude/Longitude/Timestamp columns confirmed present._extract_searchhelper, fixing a latentNameErrorwhere the dict branch referencedthings(the list branch's loop variable, undefined if only a single dict entry existed).datetime.Original dates (2023-10-15) preserved.