Convert lgRCS to artifact_processor#873
Merged
Merged
Conversation
Single LAVA table of LG RCS chat messages (message left join file_info from mmssms.db). Was an ArtifactHtmlReport that also had a latent bug: it built an empty 'tsv_list' and passed that (not data_list) to tsv()/timeline(), so the TSV and timeline outputs were always empty -- now the framework generates them from the returned rows. Timestamp (ms) -> aware UTC (blank when date<=0); dropped the dead get_offline_path helper; read-only DB access guarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the LG RCS chats artifact to LAVA
@artifact_processor— a single consolidated table ofmessage⟕file_infofrommmssms.db.Change
ArtifactHtmlReportwith a latent bug: it populateddata_listfor the HTML table but built a separate, always-emptytsv_listand passed that totsv()andtimeline()— so the TSV and timeline exports were always empty. The framework now generates all outputs from the returned rows.datetime(blank whendate <= 0, matching the original CASE).get_offline_pathhelper; query wrapped intry/except sqlite3.Error; kept themmssms.dbbasename + magisk-mirror filtering and themessage-table existence check.Verification
-d C,R); column names pass a liveCREATE TABLE(incl.read/date/body); name unique; PluginLoader 499 incl.get_lgRCS.message⟕file_info): a message with an attachment joins its file fields, adate=0message yields a blank timestamp, and a message with nofile_inforow gets NULL file fields — timestamps aware-UTC.