Convert googleChat to artifact_processor (4-way split)#879
Merged
Conversation
Splits the single Google Chat ArtifactHtmlReport (4 dynamically-named per-db reports) into four LAVA artifacts consolidating all dynamite.db files with a Source File discriminator: get_googleChat (Messages), get_googleChat_groups (Groups), get_googleChat_drafts (Drafts), get_googleChat_users (Users). - Message annotation protobuf parsing extracted into a guarded _parse_annotation helper (image / meeting / empty cases) instead of the bare try/except: pass chain. - Microsecond timestamps -> aware UTC. - Fixes the latent 'db.close' bug (missing parens -> the DB was never closed; also NameError-prone when no dynamite.db was found) via a shared _run helper that closes each db.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the Google Chat (
dynamite.db) artifact to LAVA@artifact_processor.Change
Google Chat - Messages {identifier}, etc.). Split into four artifacts that consolidate alldynamite.dbfiles into one table each, with a Source File discriminator column:get_googleChat(Messages),get_googleChat_groups(Groups),get_googleChat_drafts(Drafts),get_googleChat_users(Users)._parse_annotationhelper returning a fixed 8-field tuple, replacing the original baretry/except: passchain.datetimecolumns.db.close(missing parentheses) — the DB was never actually closed, and it referenceddboutside the loop (NameError-prone when nodynamite.dbmatched). Now each DB is opened/closed in a shared_runhelper.Verification
-d C,R); all 4 header sets pass a liveCREATE TABLE; names unique; PluginLoader 506 with all four functions._parse_annotation(image / meeting / empty) and adynamite.dbfixture exercising all four reports: joins resolve, microsecond timestamps → aware UTC, annotation parsed, Source File appended.