Convert NikeAMoments to artifact_processor (structured moments table)#895
Merged
Conversation
NikeAMoments was old-style and showed a redundant activities table plus a custom interactive JS timeline of per-run moments. The activities table is already covered (more richly) by the 'Nike - Activities' artifact, and the JS timeline can't render in LAVA, so the moment data was effectively unqueryable. Convert to a single @artifact_processor that emits 'Nike - Activity Moments': one row per activity_moment (Activity ID, Timestamp, Moment Type, Value, Description). The human-readable Description reproduces the original timeline labels (Run paused/resumed, Split KM/Mile, GPS signal lost/found); unknown moment types are now kept with a blank description instead of being dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NikeAMomentswas old-style. It rendered a redundant activities table plus a custom interactive JS timeline of per-run moments. The activities table is already covered (more richly) by the existing Nike - Activities artifact, and the JS timeline can't render in LAVA — so the moment data was effectively unqueryable.This converts it to a single
@artifact_processorthat emits Nike - Activity Moments: one row peractivity_moment(Activity ID, Timestamp, Moment Type, Value, Description).Changes
ArtifactHtmlReport+ the interactive timeline JS (add_timeline/add_timeline_script).Descriptionreproduces the original timeline labels (Run paused/resumed, Split KM/Mile, GPS signal lost/found)._ms_to_utc; helpers/style matchNikeActivities.py.Validation
ast.parseOK; 0 old-style refs (ArtifactHtmlReport/report./add_timeline/tsv/timeline).