Context-form retrofit (batch 3): powerOffReset, shutdown_checkpoints, offlinePages, deviceHealthServices_Battery#908
Merged
Conversation
…eckpoints, offlinePages, deviceHealthServices_Battery Batch 3 (6 functions / 4 files). 4-arg -> def fn(context); the Source/Source File column (and offlinePages' joined source_path) now use context.get_relative_path(). - powerOffReset / shutdown_checkpoints: 'Source File' column; also fixed pre-existing CI lint issues exposed by touching them (open() without encoding= -> encoding='utf-8'; removed unused pattern2 / logfunc). - offlinePages: 'Source in Extraction' column + joined source_path return. - deviceHealthServices_Battery: Turbo_Battery + Turbo_Bluetooth 'Source' columns (kept the W0718 disable for the existing except Exception blocks). All 6 context form; pylint 10.00.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 3 (6 functions / 4 files). Same pattern: 4-arg →
def fn(context), andcontext.get_relative_path()on theSource/Source Filecolumn (+ offlinePages' joined source-path return).Source Filecolumn. Also cleaned pre-existing CI lint issues exposed by touching them:open()withoutencoding=→encoding='utf-8'(the known ALEAPP CI failure), removed an unusedpattern2and unusedlogfuncimport.Source in Extractioncolumn + joinedsource_pathreturn.Turbo_Battery+Turbo_BluetoothSourcecolumns (kept theW0718disable for the existingexcept Exceptionblocks; droppedW0613).pylint 10.00, all 6 context form, imports clean. 12 of 28 done.