Maite modules batch 9#1327
Merged
Merged
Conversation
Updated blockedContacts, bluetoothOther, and bluetoothPairedLE artifacts to use context. Also removed unused imports
Updated to use context. Replaced plist file handling to use get_plist_file_content Changed return source file to be consistent with other artifacts
Updated artifact dict. Deleted the booking preferences artifact and replaced it with a function inside booking_booked. Changed artifacts output for source file to be consistent with other artifacts Changed datetime handling
changed datetime function to return utc datetime instead of string Also mark Last seen time column as datetime
Collaborator
|
Collaborator
|
after committing, GitHub was showing issues with booking module. turns out @djangofaiola updated this a few months back. removed the booking from this pr since its no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor artifacts to v2 and to use Context.
Also added plist validation
I tested blockedContacts, bluettothOther, bluetoothPairedLE and bluetoothPairedReg. For booking i couldn't find test data