fix: make exception broader so it can catch DatabaseError also#1378
Merged
Conversation
Collaborator
|
updated the exception because the proposed fix is way too broad. using DatabaseError will include the intended error with this pr, but also include the other errors that were on separate lines. thanks for finding this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the file was not a valid database, the code raised a
DatabaseErrorthat wasn’t being caught, since onlyOperationalErrorandProgrammingErrorwere handled. This PR broadens the exception handling to properly coverDatabaseErroras well.Before:
After:
As a result, the parsing operation can complete without the exception being thrown immediately.
ref: https://docs.python.org/3/library/sqlite3.html