Convert kik Users-in-Groups + Local Account to artifact_processor (LAVA)#1553
Merged
Conversation
First cluster: the two simple kik.sqlite user/group artifacts (same query
shape, no protobuf, no media). kikGroupadmins (blackboxprotobuf decoding) and
the media-bearing kik artifacts are handled separately.
- v1 __artifacts__ -> __artifacts_v2__; @artifact_processor with the 5-arg
iLEAPP signature (unused args underscore-prefixed; pylint 10.00, no disable
header).
- Source selected by iterating files_found + endswith('kik.sqlite') with an
empty-guard (no files_found[0]).
- Harden a latent bug: the per-row group sub-query left grouptag/groupdname/
zjid/zpurl undefined when it returned no rows -> initialize to '' each row.
- Parameterize the sub-query (was an f-string), close the db, and drop the
unused glob/os/nska_deserialize/sqlite3/datetime imports and the
ArtifactHtmlReport/tsv/timeline plumbing.
- kikLocaladmin: fix the 'Administartor' header typo -> 'Administrator'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First cluster PR of the iLEAPP modernization (following the medicalID pilot, #1552). Converts the two simple kik.sqlite user/group artifacts together — they share the same source and query shape, have no protobuf and no media.
kikUsersgroupskikLocaladminkikGroupadmins(blackboxprotobuf decoding) and the media-bearing kik artifacts (kikMessages,kikBplistmeta) are deliberately not in this PR — they'll get their own.Changes
__artifacts__→__artifacts_v2__;@artifact_processorwith the 5-arg iLEAPP signature (unused args underscore-prefixed → pylint 10.00, no disable header per house style).files_found+endswith('kik.sqlite')with an empty-guard (nofiles_found[0]).grouptag/groupdname/zjid/zpurlundefined when it returned no rows (NameError risk / stale carry-over) → initialized to''each row.glob/os/nska_deserialize/sqlite3/datetime) and theArtifactHtmlReport/tsv/timelineplumbing.kikLocaladmin: fixed theAdministartorheader typo →Administrator.Validation
ast.parseOK; 0 legacy refs; no cross-module imports of the functions.Blob).__artifacts_v2__, decorated, function name = key, no legacy registry.