Retire mobileBackup (superseded by mobileBackupplist) + relative source path#1561
Merged
Conversation
…ce path
mobileBackup parsed the same com.apple.MobileBackup.plist as mobileBackupplist
but only a subset of fields; mobileBackupplist is a strict superset (adds
BackupStateInfo.errors, DeviceTransferInfo, FSEventState).
- Delete scripts/artifacts/mobileBackup.py and fold its broader path glob
('*/Preferences/com.apple.MobileBackup.plist') into mobileBackupplist so no
extraction-path coverage is lost.
- mobileBackupplist now returns context.get_relative_path(source_path) so the
source shown in LAVA is the in-extraction path (base folder stripped) instead
of the full local on-disk path.
abrignoni
changed the title
abrignoni
force-pushed
the
retire-mobilebackup
branch
from
714bc5b to
a685a05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the redundant
mobileBackupartifact (a strict subset ofmobileBackupplist), and appliescontext.get_relative_path()to the source.Changes
scripts/artifacts/mobileBackup.py; fold its broader path glob (*/Preferences/com.apple.MobileBackup.plist) intomobileBackupplist.pathsso no extraction-path coverage is lost.mobileBackupplistnow returnscontext.get_relative_path(source_path)→ LAVA shows the clean in-extraction path (e.g.private/var/mobile/Library/Preferences/com.apple.MobileBackup.plist) instead of the full local on-disk path. (Adopting this convention for source/path fields going forward.)Validation
mobileBackup.