Convert mobileActivationLogs to artifact_processor (LAVA, context form)#1562
Merged
Conversation
Solo (complex: parses mobileactivationd.log + logs inside sysdiagnose tars). - Context single-arg form (def mobileActivationLogs(context)); no unused args, pylint 10.00. - Timestamps stored as aware UTC (assume-UTC convention; the log has no local-time note) instead of naive str(). - context.get_relative_path() applied to the returned source path(s) so LAVA shows clean in-extraction paths. - Dropped the low-value per-file 'counts' summary report (Found N entries...); the events table is the actual forensic data and the counts are derivable. - Preserve the sysdiagnose tar extraction + the date/upgrade/startup regexes; harden with try/except (ValueError) on the date parse, proper file/tar closing (was leaking handles), and skip unreadable files. - Drop ArtifactHtmlReport/tsv/logfunc/logdevinfo/is_platform_windows/os.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solo conversion (complex — parses
mobileactivationd.logand logs insidesysdiagnose_*.tar.gzarchives).Changes
def mobileActivationLogs(context):) — no unused args, pylint 10.00.str().context.get_relative_path()applied to the returned source path(s) → LAVA shows clean in-extraction paths.try/except (ValueError)on the date parse, proper file/tar closing (the original leaked handles), and skipping unreadable files.ArtifactHtmlReport/tsv/logfunc/logdevinfo/is_platform_windows/os.Validation
ast.parseOK; 0 legacy refs; reserved-word audit clean.logs/mobileactivationd.log).