Convert notificationsDuet + notificationsXII to artifact_processor (LAVA, context form)#1566
Merged
Merged
Conversation
…AVA, context form) - notificationsDuet: finish the hybrid (was a v2 header + undecorated function doing a per-file ArtifactHtmlReport AND a manual lava_process_artifact/ lava_insert_sqlite_data). Decorate with the context form, drop the 'function' key, set output_types 'standard' (was 'none'), use the single datetime-marked header set, and let the wrapper emit HTML/TSV/timeline/LAVA. Harden the blackboxprotobuf decode (try/except) and use .get() fallbacks on the proto message. SEGB timestamps already aware-UTC. - notificationsXII: v1 __artifacts__ -> v2, context form. Robust file discovery (iterate files_found, glob dirs) instead of files_found[0]+glob; AppNotification CreationDate returned as an aware-UTC datetime; guarded plist deserialize; merged the two bundle-name helpers. - Both: context.get_relative_path() on the returned source; reserved-word audit run on both header sets; pylint 10.00. Drop ArtifactHtmlReport/tsv/timeline/ logfunc/is_platform_windows/manual-lava imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notifications cluster (2 artifacts) →
@artifact_processor, context form.ArtifactHtmlReportand calledlava_process_artifact/lava_insert_sqlite_databy hand). Now decorated (context form),'function'key dropped,output_typesset tostandard(wasnone), single datetime-marked header set, wrapper emits everything. Hardened theblackboxprotobufdecode +.get()fallbacks on the proto message.__artifacts__→ v2, context form. Robust file discovery (iteratefiles_found, glob dirs) instead offiles_found[0]+glob;AppNotificationCreationDatereturned as aware-UTC datetime; guarded plist deserialize; merged the two bundle-name helpers.context.get_relative_path()on the source; reserved-word audit run on both header sets; pylint 10.00.Validation
ast.parseOK; 0 legacy refs; no cross-module imports.functionregistry.