Convert geodApplications + geodPDPlaceCache to artifact_processor (LAVA, context form)#1569
Merged
Conversation
…VA, context form)
geod/location cluster (2 simple AP.db / PDPlaceCache.db artifacts).
- v1 __artifacts__ -> v2; context single-arg form; pylint 10.00.
- Timestamps converted to aware UTC with convert_cocoa_core_data_ts_to_utc
(Mac absolute time / Cocoa seconds since 2001). PDPlaceCache already used the
Cocoa epoch in SQL; AP.db createtime assumed Cocoa (same geod family) and
noted as such.
- Marked the time columns as ('datetime'); use get_sqlite_db_records +
does_table_exist_in_db helpers instead of manual cursors.
- geodPDPlaceCache: join pdplacelookup/pdplaces, extract the place strings and
join with newlines (was '<br>' + html_escape=False).
- context.get_relative_path() on the returned source; reserved-word audited.
- Drop base64/json/sqlite3/os/version/strings(unused in apps)/ArtifactHtmlReport/
tsv/timeline/logfunc/is_platform_windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
geod/location cluster — two simple AP.db / PDPlaceCache.db artifacts.
Changes
__artifacts__→ v2; context form; pylint 10.00.convert_cocoa_core_data_ts_to_utc(Mac absolute time, seconds since 2001). PDPlaceCache already used the Cocoa epoch in SQL; AP.dbcreatetimeassumed Cocoa (same geod family, noted innotes). Time columns marked('datetime').get_sqlite_db_records+does_table_exist_in_dbhelpers instead of manual cursors.<br>+html_escape=False).context.get_relative_path()on the source.Validation
ast.parseOK; 0 legacy refs; no cross-module imports; names unique.