Convert findMy + duetLocations to LAVA @artifact_processor#1571
Merged
Conversation
- findMy: context form, FMIPAccounts.plist key/value, addTime -> aware UTC, get_relative_path on source. - duetLocations: context form, manual SEGB stream parsing preserved, location timestamps via webkit_timestampsconv (UTC), lat/lon -> framework KML via output_types 'all' (drops manual kmlgen), get_relative_path on sources. Removed dead utf8_in_extended_ascii helper and unused imports (blackboxprotobuf/mktime/StringIO/ArtifactHtmlReport/tsv/timeline/kmlgen).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes two location standalones to the LAVA pipeline (context form, UTC,
get_relative_path).findMy.py
__artifacts__→__artifacts_v2__;@artifact_processorsingle-argcontextform.get_files_found()+endswith+ empty-guard (no blind[0]).addTime→ timezone-aware UTC datetime;get_relative_pathon source.duetLocations.py
webkit_timestampsconv(UTC); Latitude/Longitude routed to the framework KML viaoutput_types: 'all'(drops the manualkmlgencall).get_relative_pathon each source; consolidates records across all matched stream files.utf8_in_extended_asciihelper and unused imports (blackboxprotobuf, mktime, StringIO, ArtifactHtmlReport, tsv, timeline, kmlgen).Validation
--disable=C,R); compile/ast OK.__wrapped__present; no cross-module imports of the old names (dead localutf8_in_extended_asciiwas not imported elsewhere; googleChat uses the ilapfuncs version).