Convert bumble + googleDuo + imoHD_Chat to LAVA @artifact_processor#1579
Merged
Conversation
Three messaging/comms apps, each split into one processor per report; context
form, UTC, framework media via check_in_media.
bumble -> bumbleMessages + bumbleAccount:
- Fixes the 'Values' reserved-word trap (header ('Key','Values') sanitizes to
the SQL reserved word; renamed to 'Value') — same class as the #1565 crash.
- Fixes a latent crash: the non-NSKeyedArchiver path used sys/plistlib/biplist
which were never imported. Now a shared _load_blob_plist helper (plistlib +
nska_deserialize). Timestamps -> aware UTC (convert_unix_ts_to_utc /
convert_cocoa_core_data_ts_to_utc); guarded the io.BytesIO(None) ordering.
googleDuo -> googleDuoContacts + googleDuoCallHistory + googleDuoClips:
- Clips media: shutil.copy2 + inline <img> -> check_in_media ('Clip','media').
- Fixes an off-by-one column bug: the original selected media_clip_md5_checksum
but labeled it 'Content Size', shifting Content/Transferred and dropping
transferred_size. Now MD5 Checksum/Content Size/Transferred Size all mapped.
- Removed a stray debug print().
imoHD_Chat -> imoHDChatMessages + imoHDChatContacts:
- Same missing sys/plistlib/biplist import crash fixed via _load_blob_plist.
- Attachment media: shutil.copy2 + inline <img> -> check_in_media.
- Guarded plist['type'] (was an unguarded index on failed/'' parse).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes three messaging/comms apps to the LAVA pipeline. Each multi-report artifact is split into one processor per report; context form, UTC, framework media via
check_in_media. Clustered as they're the same class of app.bumble →
bumbleMessages+bumbleAccount('Key','Values')sanitizesValues→ the SQL reserved word (same class as the Fix mobileBackupplist LAVA crash: 'Values' column is a SQL reserved word #1565Valuescrash) — renamed toValue.sys/plistlib/biplistthat were never imported. Now a shared_load_blob_plist(plistlib + nska_deserialize). Timestamps → aware UTC; guarded theio.BytesIO(None)ordering.googleDuo →
googleDuoContacts+googleDuoCallHistory+googleDuoClipsshutil.copy2+ inline<img>→check_in_media(('Clip','media')).media_clip_md5_checksumbut labeled itContent Size, shifting Content/Transferred and droppingtransferred_size. Now MD5 Checksum / Content Size / Transferred Size are all mapped.print().imoHD_Chat →
imoHDChatMessages+imoHDChatContactssys/plistlib/biplistimport crash fixed via_load_blob_plist.shutil.copy2+ inline<img>→check_in_media; guardedplist['type'](was an unguarded index on a failed/empty parse).Validation
get_*names.