Convert the iCloud cluster (iCloudWifi + icloudMeta + icloudSharedalbums)#1586
Merged
Conversation
Three iCloud-related artifacts -> context form, UTC. - iCloudWifi: single report; replaced files_found[0] blind index with iterate+endswith+guard; 'Added At' parsed to a datetime (was str()). - icloudMeta: consolidated the per-file 'iCloud - File Metadata N' reports into one table across files; btime/ctime/mtime were naive-local datetime.fromtimestamp(x/1000) -> convert_unix_ts_to_utc (correct aware UTC); fixed the '' > 0 TypeError when a time key is absent; guarded file_flags and the JSON line/last_editor parse. - icloudSharedalbums: split the 4 reports into icloudSharedOwnerInfo / icloudSharedAlbumData / icloudSharedPersonInfo / icloudSharedEmails; fixed undefined-var NameErrors (albumtitle/dcim* when keys absent) via .get(); fixed header typos (Clowd->Cloud, Ownewr->Owner, LAst->Last); get_relative_path on File Location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes three iCloud-related old-style artifacts to LAVA. Context form, UTC. 6 processors total.
iCloudWifi (1)
files_found[0]blind index with iterate+endswith+guard;Added Atparsed to a datetime (wasstr()).icloudMeta (1)
iCloud - File Metadata Nreports into one table across files.btime/ctime/mtimewere naive-localdatetime.fromtimestamp(x/1000)→convert_unix_ts_to_utc(correct aware UTC; verified1678307200000ms →2023-03-08 20:26:40Z).'' > 0TypeError when a time key is absent; guardedfile_flagsand the JSON line / last-editor parse.icloudSharedalbums (4 → split)
icloudSharedOwnerInfo,icloudSharedAlbumData,icloudSharedPersonInfo,icloudSharedEmails(each dispatches on its plist filename underPhotoCloudSharingData).albumtitle/dcim*when keys absent) via.get(); fixed header typos (Clowd→Cloud,Ownewr→Owner,LAst→Last).Validation
files_found[0]/fromtimestamp/timezone_offsetgone).