Convert simInfo + recentApphistory + queryPredictions to LAVA#1587
Merged
Conversation
…_processor Three small system artifacts -> context form, UTC. - simInfo: split into simInfoUUID + simInfoLabelStore; timestampcalc was naive datetime.fromtimestamp(int(ts)) -> convert_unix_ts_to_utc (correct aware UTC), guarded empty/non-int ts; fixed the 'MDM' header typo (value is mdn -> 'MDN'); dropped duplicate datetime import and unused os/json. - recentApphistory: biplist -> plistlib; CarPlay timestamp -> convert_unix_ts_to_utc; iterate+endswith+guard source selection. - queryPredictions: replaced files_found[0] blind index with iterate+endswith+guard; datetime(creationTimestamp,'unixepoch') is UTC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernizes three small system artifacts to LAVA. Context form, UTC. 4 processors.
simInfo (→ 2)
simInfoUUID+simInfoLabelStore.timestampcalcwas naivedatetime.fromtimestamp(int(ts))→convert_unix_ts_to_utc(correct aware UTC; guarded empty/non-int).MDMheader typo — the value ismdn, so →MDN. Dropped the duplicatedatetimeimport + unusedos/json.recentApphistory (CarPlay)
biplist→plistlib; timestamp →convert_unix_ts_to_utc;iterate+endswith+guardsource selection.queryPredictions
files_found[0]blind index withiterate+endswith+guard;datetime(creationTimestamp,'unixepoch')is UTC.Validation
fromtimestamp/files_found[0]/biplistgone).