Convert dhcphp/dhcpl to context form + relative Source File + UTC#1608
Merged
Conversation
Finish the relative-path sweep for the two DHCP artifacts that were on the legacy 5-arg signature (so they couldn't take the simple get_relative_path wrap): - Convert both to the single-arg context form (removes the unused report_folder/seeker/ wrap_text/timezone_offset args that were the lint debt). - Source File column now uses context.get_relative_path (was the full on-disk path). - dhcpl: store LeaseStartDate as UTC (plist <date> is UTC) instead of shifting it to the examiner's local timezone via convert_plist_date_to_timezone_offset; guard plist read. - dhcphp: add encoding= to open(); fix the paths tuple (was a bare string). - version/date -> creation_date/last_update_date; preserves author (@AlexisBrignoni on dhcphp). Validation: pylint 10.00 both; runtime-tested parsing (relative source paths, UTC LeaseStartDate, MAC formatting); PluginLoader loads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finishes the relative-path sweep: the two DHCP artifacts (DHCP Hotspot Clients + DHCP Received List) were on the legacy 5-arg signature, so they couldn't take the simple
get_relative_pathwrap the other 28 got.Changes
report_folder/seeker/wrap_text/timezone_offsetargs — the lint debt).context.get_relative_path(was the full on-disk path).LeaseStartDateas UTC (plist<date>is UTC) instead of shifting it to the examiner's local tz viaconvert_plist_date_to_timezone_offset; guards the plist read.encoding=toopen(); fix thepathstuple (was a bare string).version/date→creation_date/last_update_date; author preserved (@AlexisBrignoni on dhcphp).Validation
LeaseStartDate(unshifted), MAC formatting, non-wanted keys excluded.This closes out the path-in-data-column sweep — every artifact's source column now shows the clean in-extraction path.