whatsApp: fix AttributeError crash on messages without forward metadata#1609
Merged
Conversation
decoded_data.get('21') (forwarded-message sender ID) is None for any message that
isn't a forward, so .decode('utf-8') raised AttributeError and aborted the whole
whatsAppMessages artifact. Guard it: decode only when the field is bytes, else ''.
Also default field 17 to '' so number_forward shows '' instead of the literal 'None'
when the field is absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
whatsAppMessagescrashed with:Protobuf field
21(the forwarded-message sender ID) is absent on any message that isn't a forward — i.e. most messages — so.get("21")returnsNoneand.decode()raises, aborting the entire artifact.Fix
bytes, else'':''sonumber_forwardshows''instead of the literal'None'when absent.Pre-existing bug (not from the recent conversions). pylint 10.00/10; verified present-bytes / absent / None all handled without crashing.