Fix LAVA CREATE TABLE crashes from duplicate/reserved column names (cashApp, tikTok)#1612
Merged
Merged
Conversation
Both crashed lava_create_sqlite_table once they had a record: - cashApp: two columns were both labeled 'Transaction State' (duplicate column name). The second one actually holds the payment NOTE (row[4]), so it's renamed to 'Note' - fixes the crash and corrects the mislabeled column. - tikTok (tiktok_contacts): a column named 'Table' sanitizes to the SQL reserved word 'table' (the framework doesn't quote identifiers). Renamed to 'Source Table' (it holds the source table name). Pre-existing bugs surfaced during testing. A codebase-wide CREATE TABLE audit (duplicate + reserved-word column names) confirms no other artifacts are affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both artifacts crashed in
lava_create_sqlite_tableas soon as they had a record:Fixes
Transaction State. The second actually holds the payment NOTE (row[4]) — renamed toNote. Fixes the duplicate-column crash and corrects the mislabeled column.tiktok_contacts): a column namedTablesanitizes to the SQL reserved wordtable(the framework doesn't quote identifiers). Renamed toSource Table(it holds the source table name).Both are pre-existing bugs surfaced during testing (not from the recent conversions).
Validation
data_headers) confirms no other artifacts are affected.