Skip to content

feat: allow custom output folder name#1631

Merged
Johann-PLW merged 1 commit into
abrignoni:mainfrom
JamesHabben:feat/custom-output-folder
Jul 8, 2026
Merged

feat: allow custom output folder name#1631
Johann-PLW merged 1 commit into
abrignoni:mainfrom
JamesHabben:feat/custom-output-folder

Conversation

@JamesHabben

Copy link
Copy Markdown
Collaborator
  • note: CLI and framework functionality was already in place
  • GUI now has textbox to allow customization of output folder name
  • guards illegal folder name characters in both CLI and GUI
  • guards to prevent overwriting existing folder in CLI and GUI
  • illegal character file/folder functions moved from ilapfuncs to new modularized /leapp_functions/ path
  • ilapfuncs imports old functions from new path to keep backwards compatibility
  • left commented out def lines in ilapfuncs to note they have been moved

@JamesHabben

Copy link
Copy Markdown
Collaborator Author
image

@stark4n6

stark4n6 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

@JamesHabben do we want the label to say something like "Custom Folder Name (optional)"?

@Johann-PLW

Copy link
Copy Markdown
Collaborator

@JamesHabben do we want the label to say something like "Custom Folder Name (optional)"?

I'm not sure it is relevant to rename the label as it is the name of the folder where the reports will be saved: Output_path + folder_name.

By default, it uses the convention we've always used: leappAppName_Output_YYYY-MM-DD_NameOfTheDay_HHMMSS.
By the way, I think we could remove the name of the day.

@Johann-PLW Johann-PLW merged commit c4a560d into abrignoni:main Jul 8, 2026
1 check failed
@JamesHabben

Copy link
Copy Markdown
Collaborator Author

I agree with removing the day name. Makes it extra long for sure

@JamesHabben JamesHabben deleted the feat/custom-output-folder branch July 8, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants