biomeAppWebUsage: use Context form#1633
Merged
Merged
Conversation
Bring the one remaining biome artifact onto the Context signature used by the other 22 (def get_biomeAppWebUsage(context) + context.get_files_found()). No behavior change: it already stored UTC and used typed datetime headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup:
biomeAppWebUsage.pywas the only biome artifact still on the legacy 5-parameter signature — the other 22 all use the Context form. This brings it in line.Change (2 lines)
def get_biomeAppWebUsage(files_found, _report_folder, _seeker, _wrap_text, _timezone_offset):→def get_biomeAppWebUsage(context):for file_found in files_found:→for file_found in context.get_files_found():No behavior change
The artifact already stored UTC (
webkit_timestampsconv, no timezone conversion) and already used properly typed('...', 'datetime')headers, so nothing else needed to change. Field mappings,typess, the Written/Deleted handling, and author attribution are untouched.Validation
py_compileclean.__wrapped__signature is now(context)